Repository navigation
chore: trim obsolete tests, make the suite hermetic, and speed it up - #94
Merged
Merged
Conversation
- Delete tests that only pinned removed code, legacy schemas, or docs wording; loosen three literal pins to structural checks. - extract_evidence: require --source-manifest and drop the direct-PDF mode no caller uses. - Remove the unreferenced paper-glossary optimization plan. - Tests run offline (empty HTTP cassette) and OCR-free (shadow pytesseract); one OCR test runs only where tesseract is installed. - Import pytesseract lazily. - visual_review_cli tests plan once per module and call main in-process. - CI: cancel superseded runs, 15-minute timeout, lint and compile on ubuntu only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The test suite was slow and carried tests that guarded code, schemas, and docs wording that no longer exist. This PR removes those, makes the suite independent of the network and of a local OCR install, and cuts the wall time.
test_no_legacy_rewrite_helpers.py;test_contracts_consistency.py;test_contracts_consistency.py.extract_evidence.py:--source-manifestis required, and the unused direct-PDF mode is gone, along with--max-pagesand its 5 tests.run_pipelineandrun_statealready pass the manifest.skills/paper-glossary/references/optimization-implementation-plan.md: nothing referenced it.pytesseractthat fails to import. One new OCR test runs only wheretesseractis installed.pytesseract: it loads on first OCR use instead of on every import ofextract_pdf_assets.test_visual_review_cli.py: plans once per module, copies the run per test, and callsmain()in-process. Four tests still go through a real subprocess.Evidence
pytest -n autopytesttest_visual_review_cli.pypython3 -m pytest -q -n auto: 1730 passed, 1 skipped (the OCR test, no tesseract here).python3 -m ruff check skills tests: clean.python3 -m pytest -q -m corpus: 368 passed, 21 xfailed.Merge Danger
--source-manifest.extract_evidence.pyby hand without--source-manifestnow gets an argparse error. Both in-repo callers already pass it.🤖 Generated with Claude Code