Repository navigation
fix(deps): bump golang.org/x/crypto to v0.55.0 for CVE-2026-56854 - #91
Merged
Merged
Conversation
Trivy image scan flagged CRITICAL CVE-2026-56854 (x/crypto/ssh auth bypass) in the v0.1.17 release image; scan-docker gates stable tags on CRITICAL,HIGH findings. Upgrade x/crypto and its transitive x/ module closure. Local trivy rescan of the rebuilt binary is clean and govulncheck reports 0 reachable vulnerabilities.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
x/vuln v1.8.0 requires go >= 1.26.0 while CI runs go 1.25.13 with GOTOOLCHAIN=local, so the floating @latest install broke the govulncheck job. Pin to the last release compatible with go 1.25; the vulnerability database is fetched at runtime so detection stays current.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
v0.1.17 的 Release workflow 中
scan-docker失败：Trivy 在镜像内的 Go 二进制中发现golang.org/x/crypto v0.53.0命中 CVE-2026-56854（CRITICAL，x/crypto/ssh认证绕过，fixed in v0.55.0）。Alpine 基础层干净，仅 gobinary 层有这一条发现。scan-docker对 stable tag（无-）设置exit-code: 1，CRITICAL/HIGH 发现即失败；beta tag 非阻塞，因此此前的 beta 发布未暴露该问题。govulncheck 在 9/4 的 main CI 通过是因为当时通告尚未进入漏洞库。改动
golang.org/x/cryptov0.53.0 → v0.55.0，连带go mod tidy收敛的 x/ 传递依赖（net/sys/term/text/sync 小版本）。验证
go build ./...、go vet ./...、go test ./...通过。govulncheck ./...（与 CI 相同命令）：可达漏洞 0。pkg/p2p的TestSessionIPv6OnlyLoopback在全量并发下偶发失败，单独跑与未升级的 main 上均复现不了，属既有 flaky，与本改动无关。后续
合并后建议直接发 v0.1.18 替换 stable 通道上的 v0.1.17（该 release 已发布且镜像带 CRITICAL 漏洞，不建议改写已发布 tag）。