Repository navigation
run Zend_Session, Zend_OpenId and Zend_Soap tests in CI - #249
Open
falkenhawk wants to merge 1 commit into
Open
falkenhawk wants to merge 1 commit into
falkenhawk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI never ran the tests of
Zend_Session,Zend_OpenIdandZend_Soap.tests/AllTests.phpkeeps them in a separate suite,suiteBuffered(), because they used to need that no output is sent before them.Only
php tests/AllTests.phpruns that suite. phpunit, as used in CI, runsAllTests::suite()only.In addition, CI did not install the
soapextension.So problems in these components went unnoticed, see the fixes below and the PRs this one depends on.
1) Running the suites
phpunit.xml.distgets a second testsuite with the files ofsuiteBuffered(), run before the regular suite, likephp tests/AllTests.phpdoes.The tests that need no prior output run in separate processes, so they pass with phpunit too.
CI installs the
soapextension.2) Zend_Soap
Zend_Soap_Server::addFunction()read theSOAP_FUNCTIONS_ALLconstant on every call, which php 8.4 deprecated. It now compares with the value of the constant,999.E_USER_ERROR, which php 8.4 deprecated. A@hides only that deprecation: error handlers are still called, soZend_Soap_Serverstill turns the error into a SOAP fault, which is what the test checks.Other forks:
@SOAP_FUNCTIONS_ALL(Shardj/zf1-future#519), which still reads the constant and will break once php 9 removes itZend_Soap_Server::FUNCTIONS_ALLfor the value, and uses the same@trigger_error()in the tests3) Zend_Session in unit test mode
In unit test mode
Zend_Session::start()skipssession_start(), so$_SESSIONwas never defined.php < 8.1 warns when a key of an undefined
$_SESSIONis unset, so theZend_OpenIdprovider tests failed on php 7.1 - 8.0.start()now defines$_SESSIONin unit test mode, assession_start()would. Nothing changes outside of unit test mode.Merge order
CI of this PR stays red until these are merged:
Zend_SessionTesttests failing on php 8.1+DbTableTestfailing on php 8.6OpenIdTestending with a fatal error on OpenSSL 3+, which stops the whole test run