Repository navigation
[zend-controller] fix undefined array key warning for empty route variables - #241
Open
falkenhawk wants to merge 2 commits into
Open
falkenhawk wants to merge 2 commits into
falkenhawk wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the path segment of a route variable is empty,
Zend_Controller_Router_Route::match()uses the default of the variable instead.If the variable has no default, it reads an array key that does not exist:
Double slashes like this come from broken links or from scanners trying out URLs.
Apps that turn warnings into exceptions answer such requests with a 500 error.
Fix
The variable is set to
nullwhen it has no default - the value it already got, now without the warning.The route still matches as before.
Not matching the route at all would arguably be more correct, but it would change which route handles such URLs, so the current behavior is kept.
Ported from a private repository, based on work by @marcing. There, the route no longer matches.