Repository navigation
[zend-captcha] fix TypeError on array input in Zend_Captcha_Word::isValid() - #239
Open
falkenhawk wants to merge 1 commit into
Open
falkenhawk wants to merge 1 commit into
falkenhawk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1) Array input
A tampered request like
captcha[input][]=xsends an array instead of the typed word.Zend_Captcha_Word::isValid()passes it tostrtolower(), which throws aTypeErroron php 8, so the request ends with a 500 error. php 7 only warned.An array in
captcha[id][]=xends up in the session namespace name asArray, with an "Array to string conversion" warning.Both now fail validation with the
badCaptchaerror, the same result php 7 ended up with after the warning.Only arrays are rejected, all other values are handled as before.
2) php 8.5: captcha without a name
A captcha used without
Zend_Form_Element_Captchahas no name, soisValid()looks up$value[null], which php 8.5 deprecated:The name is now cast to a string. A
nullkey has always meant'', so the lookup itself does not change.Other forks
mobtitude/zendframework1#9 casts the input to a string.
That avoids the
TypeError, but an array input then becomes the wordArraywith a warning, and the id and the missing name are not handled.Ported from a private repository, based on work by @marcing.