Repository navigation
php 8.6 compatibility - #237
Merged
Merged
Conversation
falkenhawk
force-pushed
the
php86-compat
branch
from
November 4, 2026 14:10
7de2656 to
5e5a4f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for php 8.6 compatibility. All changes are backward-compatible with php 7.1+.
1) php 8.6 deprecations
is_integer()→is_int(),is_double()→is_float()across 26 filesspl_object_hash()in zend-navigation, zend-amf, zend-pdf - on php 8.6+ the same 32-char value is built fromspl_object_id()(identical output since php 8.1), older versions keep callingspl_object_hash(), so return values ofZend_Navigation_Page::hashCode()and keys ofextractFonts()don't changeZend_Db_Adapter_Pdo_Sqlite::__construct(),Zend_Server_Reflection_Node::__construct()andZend_Service_LiveDocx::__destruct()SORT_STRINGinstead ofSORT_LOCALE_STRING- same order under the defaultClocale2) leaked error handlers hiding deprecations
a chain of error handlers that were never restored silently swallowed every error from
Zend_View_Helper_HeadMetaTestonward (rest of zend-view, zend-wildfire, zend-xmlrpc) - on every php version, CI includedZend_Config_Xmlleft its error handler installed when loading failed (invalid file, or XML rejected byZend_Xml_Security) - this also affected applications catching that exceptionHeadMetaTest,XmlRpc_ResponseTestandEmailAddressTestdeprecations uncovered by this (php 8.1/8.2):
key()/current()called onSimpleXMLElementinZend_XmlRpc_Valuepreg_match_all()when used withZend_Controller_Request_HttpTestCaseWildfireTestfixtures3) CI
Assisted by Claude (Opus 5.5, xhigh).