Repository navigation
ci: turn on jactionlint's default profile - #7
Merged
Merged
Conversation
Fix the 13 findings the default profile reports and set profile: default. - missing-timeout (6): 5 minutes for lint, sanity checks, image builds and the published-image commitlint job; 8 for commitlint (~100 s); 6 for publish (63-78 s). - concurrency-limits (3): ci.yml groups per ref and cancels superseded runs except on main; commitlint.yml cancels superseded PR runs only; publish-image.yml queues every tag run (cancel-in-progress: false, queue: max) so no release is cancelled or skipped. - duplicate-triggers (1): commitlint.yml runs on pushes to main and on pull requests, not on every branch push as well. - dependabot-cooldown (3): 7-day cooldown on the github-actions, npm and docker entries, matching the pre-commit one. Refs GLB-32 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
profile: defaultin.github/jactionlint.yamland fixes the 13 findings it reports.missing-timeout(6):timeout-minutesper job, 3-5x the last six successful runs with a 5-minute floor. Lint, Sanity Checks, Image builds and commitlint-from-published-image get 5 (all under 60 s). commitlint gets 8 (93-104 s). publish gets 6 (63-78 s).concurrency-limits(3):ci.yml(push only): group per ref,cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}, so every push tomainstill gets a result.commitlint.yml: the PR-only cancel block.publish-image.yml:group: ${{ github.workflow }},cancel-in-progress: false,queue: max.duplicate-triggers(1):commitlint.ymlruns onpushtomainand onpull_request. It no longer runs twice for a branch that has a PR. A branch push without a PR no longer runs it.dependabot-cooldown(3):cooldown.default-days: 7on the github-actions, npm and docker entries, matching the pre-commit one.Publishing:
publish-image.ymlbuilds and pushes the same image tags the same way. What changes is that tag runs no longer overlap: a second tag pushed while one is publishing waits, and every queued tag publishes in order instead of a newer waiting run replacing an older one. The job is also capped at 6 minutes. Permissions are unchanged (contents: read,packages: writeon the one job), and there is no cache.Verified locally:
jactionlintexits 0. Removing the publish job's timeout makes the hook fail (missing-timeout).prek run --all-filespasses.Linear: GLB-32
🤖 Generated with Claude Code