Repository navigation
feat(eslint-config): resolve import aliases per theme from the project layout - #151
Closed
YvetteNikolov wants to merge 2 commits into
Closed
YvetteNikolov wants to merge 2 commits into
YvetteNikolov wants to merge 2 commits into
Conversation
…t layout Every theme gets an @<theme>/scripts alias instead of only @sage/scripts. In projects without a theme named sage the alias falls back to the default theme so shared starter code keeps resolving. .cjs and .mjs files are now linted too.
YvetteNikolov
requested review from
FreakyWizard,
JasperS20,
WybeBosch,
Yannicvanveen,
laravdiemen and
rivanuff
and removed request for
a team
October 8, 2026 13:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #144. Stacked on #150.
resolveImportAliasesusestryResolveThemeContextfrom shared-utils: every theme gets an@<theme>/scriptsalias in brave-root, the local./resources/scriptsin theme-root.@sage/scriptsstays available; in projects without asagetheme it points at the default theme so starter code keeps resolving..cjsand.mjsfiles are linted with the JS rules (the shared resolver is a.cjsfile).