Repository navigation
fix(xml-codec): reuse parsed list keys during child traversal - #52
Merged
lllyfeng merged 1 commit intoOct 9, 2026
Merged
Conversation
lllyfeng
approved these changes
Oct 8, 2026
lllyfeng
left a comment
lllyfeng
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @Deepya1502. The fix looks correct and the new test does cover it. This conflicts with #50 (and #51), so please rebase onto main once #50 is merged, before this goes in.
Contributor
|
#50 is now merged. @Deepya1502, could you please rebase this onto the latest main and resolve the conflicts? I'll merge once CI is green. |
Attach the existing identifier key leaf instead of reparsing its XML element. Record add-key failures as validation results and continue processing remaining children; cover key identity and failure handling with XML tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Deepya1502
force-pushed
the
work/xml-existing-list-keys
branch
from
October 9, 2026 05:28
c144666 to
05b0d79
Compare
Contributor
Author
|
@lllyfeng , rebased the branch onto main and committed the changes, conflicts have been resolved. Please check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YangDataExceptionfrom key insertion as a validation record and continue parsing remaining children instead of throwingIllegalStateException.Independent follow-up to the list-key handling review on #50; this does not include the separate XML recursion refactor.
Validation
mvn -q -pl yangkit-data-xml-codec -am -Dtest=XmlCodecBasicTest,XmlCodecComprehensiveTest -Dsurefire.failIfNoSpecifiedTests=false test