Repository navigation
Restrict the printed vitals reports to the version asked for - #268
Merged
Merged
Conversation
issues --version-code filtered the cluster search alone, so the sample report printed under it could come from any build in the cluster. A vc107 query printed a vc63 device line, which reads as that build's report. errorReports:search takes the same filter, so pass it there too. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <xroche@gmail.com>
The review found the added clause saying what the PR body already says, at twice the length. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <xroche@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
play_vitals.py issues --version-codefiltered the cluster search only, so the report it printed could come from any build in the cluster. A vc107 read printed a vc63 device line, which a reader takes for vc107's own report.errorReports:searchaccepts the same filter, so this passes it there too.