Skip to content
This repository was archived by the owner on Oct 9, 2026. It is now read-only.

test: steering tests wait as long as a loaded runner needs - #51

Closed
mekjr1 wants to merge 1 commit into
mainfrom
test/steering-waits
Closed

mekjr1 wants to merge 1 commit into
mainfrom
test/steering-waits

Conversation

@mekjr1

@mekjr1 mekjr1 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

TestAgentLoop_Steering_SkipsRemainingTools failed on windows-latest in run 37566619049 on main: "timeout waiting for tool_one to start", after 2.25 s.

It's the cause #28 found for TestRunTurn_HardAbort. On that runner a turn's setup took 2 to 4 s, and the test allowed 2 s for the turn to set up, call the model and start the tool. Its other waits in steering_test.go make the same bet: 1 to 5 s for the first model call to start, a tool to start, Run to stop, a reply to arrive, or the turn to finish.

Every wait in the file for something that must happen now uses one limit, steeringWait, 10 s. Only a failing test waits that long, so passing runs take the time they did. The two 10 ms polling ticks stay, and so does the 300 ms check that nothing more arrives after /stop. That one asserts an absence, so a longer wait would only slow it down.

Test only; no CHANGELOG line.

@mekjr1

mekjr1 commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #63, which includes this change or replaces it.

@mekjr1 mekjr1 closed this Oct 9, 2026
@mekjr1
mekjr1 deleted the test/steering-waits branch October 9, 2026 03:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant