Repository navigation
feat(provider): upload local LOGO images when creating services - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider creation now accepts a local LOGO image:
The CLI validates a readable regular image file (JPG/PNG/GIF/WebP, up to 10 MB), uploads multipart bytes using the existing scoped platform API Key, and sets the returned remote URL as the service's
logoUrlbefore creation. Upload failures stop creation and exit nonzero; neither upload nor create is automatically retried. Existing JSONlogoUrland no-logo requests remain compatible, and supplying a local file with an existing URL fails explicitly. Other provider operations reject--logo-filerather than ignoring it.Help and both bundled provider guides/skill entry point cover usage, permissions, conflicts, failures and verification. Storage credentials remain server-side. Upload and creation are separate writes; a failed create may leave an unused image. Inspect state before retrying an ambiguous create.
Requires the matching backend endpoint before deployed use: https://github.com/xapi-labs/xapi-backend/pull/521 (dev).
Validation:
bun install --frozen-lockfilepassed.bun run typecheckpassed.bun run buildpassed.bun run testpassed: 1,456 tests, 95 files, zero failures.npm pack --dry-run --ignore-scriptspassed.Local HTTP tests use a fixture server; deployed R2/public-image/web-console verification is pending backend deployment. This does not publish an npm package or merge any PR. Auto-merge remains disabled. The
feat(provider)classification covers the new CLI behavior and matching bundled-skill workflow; Release Please retains version/release authority.Kanby-Task: KANBY-105