Repository navigation
test(cli): handle escaped paths and native timer rounding - #56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix six local test failures: Workers build fixtures used URL
.pathnameas a filesystem path, leaving spaces encoded as%20; the empty-upload deadline fixture required an exact wall-clock lower bound despite native timer rounding.Use
fileURLToPath()for filesystem paths and exercise a source directory containing spaces,#, and%in every Workers build fixture. Measure empty-upload duration withperformance.now()and allow 5ms of scheduler rounding around its 400ms lower bound. Preserve timeout-error, producer cancellation, nonempty pull-count, and prompt termination assertions. Production code is unchanged.Validation:
bun install --frozen-lockfilepassedbun run typecheckpassedbun run buildpassednpm pack --dry-run --ignore-scriptspassedbun run testin a checkout with spaces in its path: 1407 passed, 0 failedNo release or live xAPI verification.