Skip to content

fix(android): preserve SDK serialization in minified apps - #7

Merged
antonwhop merged 1 commit into
mainfrom
codex/java-android-consumer-rules
Nov 15, 2026
Merged

antonwhop merged 1 commit into
mainfrom
codex/java-android-consumer-rules

Conversation

@antonwhop

@antonwhop antonwhop commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Why / Prompt

  • Minified Android apps can fail to serialize SDK requests when R8 removes the generated filter Jackson instantiates through reflection. The card-market consumer reproduced this on an optimized Android APK.

What changed?

  • Bundle Android consumer rules in the SDK JAR to preserve Jackson model annotations, request/response models, and NullableNonemptyFilter.
  • Protect the rules through regeneration and check for them in the independently installed Maven consumer.
  • Validated with 60 passing SDK tests, local Maven staging, and the installed consumer. The optimized Android probe also passes with no app-owned SDK rules; R8 records the rules coming from the Maven JAR.
  • No version bump or publication. The SDK remains at its existing placeholder version.

@antonwhop
antonwhop marked this pull request as ready for review November 15, 2026 02:53
@antonwhop
antonwhop merged commit 3f3adb7 into main Nov 15, 2026
7 checks passed

This branch was successfully deployed

1 active deployment
dry-run — c7f848de Deployed Nov 15, 2026 by antonwhop via publish #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant