Conversation
Read the created entity from Widar's res field instead of last_res in both the subject and ShEx forms. Previously, successful edits entered the error branch, leaving the spinner visible and hiding the created-item link. Retrying could create duplicate items. Clear the spinner on failure and warn when no item ID is returned. Add regression tests for successful, failed, and incomplete responses. I saw this on phabricator somewhere, however can't currently find the task, but expeirenced this while setting up a dev environment...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read the created entity from Widar's res field instead of last_res in both the subject and ShEx forms.
Previously, successful edits entered the error branch, leaving the spinner visible and hiding the created-item link. Retrying could create duplicate items.
Clear the spinner on failure and warn when no item ID is returned. Add regression tests for successful, failed, and incomplete responses.
I saw this on phabricator somewhere, however can't currently find the task, but expeirenced this while setting up a dev environment...