Conversation
Bug: T357109
Allow whitespace between a shape label and `{`, as permitted by ShExC,
and handle EXTRA declarations with normal token spacing. Cradle
previously missed these valid schemas and omitted their property fields.
Bug: T357109
Use declared prefix mappings to recognize properties in the local /prop/direct/ namespace, rather than requiring the literal wdt: prefix. Bug: T357109
addshore
force-pushed
the
T357109-parsing-improvements
branch
from
September 30, 2026 19:09
13aaf1f to
1b79090
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should probably be up streamed if merged (if upstream is maintained)
fix: recognize valid ShEx shape definitions
fix: resolve ShEx prefixes for local properties
Two things highlighted in https://phabricator.wikimedia.org/T357109