Repository navigation
Keep short words between removed silences - #115
Merged
Merged
Conversation
Remove silences cuts the pause on each side of a word. When the word is shorter than ~0.25s, the two cuts were less than MERGE_GAP apart, so addManualCut and getCutRanges joined them into one cut that covered the word. The word dropped out of the edit and Restore silences found no word-free cut to bring back. Manual cuts now only join when they overlap or touch, and getCutRanges no longer bridges a gap that holds a kept word.
|
@Bortlesboat is attempting to deploy a commit to the wassgha's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove silences cuts the pause on each side of a word, and when the word is shorter than about 0.25s the two cuts were close enough that addManualCut and getCutRanges joined them into one cut over the word. The word dropped out of the edit and Restore silences had nothing to bring back. Manual cuts now only join when they overlap or touch, and getCutRanges will not bridge a gap that holds a kept word. Added a test in silences-test.ts.
Fixes #90