Repository navigation
feat(i18n): add Italian interface language - #113
Merged
Merged
Conversation
For wassgha#97. Add it as a supported UI locale: messages/it.ts with every key from the English catalog, electron/locale/it.ts for the desktop app menu, both registered in their catalogs, and it added to UI_LOCALES / UI_LOCALE_META / MATCH_ORDER (nsis code it_IT) so detection, the language picker and the NSIS installer all pick it up without any other code change, since those are already data-driven from this list. Added italian detection/translation assertions to tests/i18n-test.ts (it fail before this change, it pass after), and the existing completeness loop now also check it has every key. Signed-off-by: bluzername <bluzerasi@gmail.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Someone is attempting to deploy a commit to the wassgha's projects Team on Vercel. A member of the Team first needs to authorize it. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
For #97 (the Italian part).
Add
itas a supported UI language: a fulllib/i18n/messages/it.tscatalog (every key from the English one), anelectron/locale/it.tsfor the desktop app menu, and both registered in their catalogs.itis also added toUI_LOCALES/UI_LOCALE_META/MATCH_ORDERinlib/i18n/locales.ts, with NSIS codeit_IT.That is all the new code needs. Language detection, the Settings language picker, the boot script and the NSIS installer language list are already data-driven off
UI_LOCALES, so they pick Italian up automatically, no other file change it.Why
The issue ask for Italian support so Italian creators can use Rescript in their own language. The translations try to match the register already used in
es.ts/fr.ts/pt.ts(same short, plain UI voice, same handling of{placeholders}).Tests
tests/i18n-test.tsis the repo's own completeness check (every locale must have every English key, non-empty). I added two Italian-specific assertions there too (it-ITsystem-language detection,common.settingstranslation, NSIS code present) — they fail with "italian detection" / module errors before this change (Italian is not a known locale yet) and pass after.Not run:
test:ffmpeg(needs the bundled native ffmpeg binary, unrelated to this change) and the Electron package/dist steps.Checklist
test:i18ngreen, including new Italian assertions