Repository navigation
Catch auto-updater check/download rejections - #110
Merged
Merged
Conversation
electron-updater emits "error" and then re-throws from both the checkForUpdates() promise and the autoDownload downloadPromise. Neither was handled, so network failures mid-download (ERR_CONNECTION_TIMED_OUT) surfaced in Sentry as unhandled rejections. Errors are still logged via the existing "error" listener and the hourly check retries. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Sentry issue 7652109640:
Error: net::ERR_CONNECTION_TIMED_OUT(unhandled,auto.node.onunhandledrejection). The report came from a Windows client on 1.2.1 whose connection dropped while downloading the v1.2.3 installer.With
autoDownload = true, electron-updater returns adownloadPromisefromcheckForUpdates(). Nothing awaits it, and when the download fails the library emitserrorand then re-throws. Thevoid autoUpdater.checkForUpdates()calls had the same problem when the check itself failed. In both cases the error was already logged and then also reported as an unhandled rejection.Both call sites now go through a
checkForUpdates()helper that catches the check and download promises. Failures are still logged by the existingautoUpdater.on("error")listener, and the hourly interval retries.Test plan
npm run typecheck:electronpasses🤖 Generated with Claude Code