Repository navigation
Conversation
…he per-test makes
Every kernel and regression test links a sw/kernel library, and each test's
own Makefile builds it on demand. With make -jN at tests/kernel or
tests/regression on a tree where the library was not built yet, every test
directory started its own build of sw/kernel at the same time: a clean -j8
run compiled and archived the library four times concurrently, and an
archive step could miss an object another build was rewriting
("ar: vx_spawn.c.2.o: No such file"). tests/Makefile runs kernel and
regression side by side and so raced the same way, and the kernel tests'
runs built a missing simulator once per test.
Build the library once, as a prerequisite of build-% and run-% in
tests/kernel and tests/regression and of kernel and regression in
tests/Makefile, and in tests/kernel build a missing simulator once
(sim-<backend>) before the per-test runs, so the per-test makes find both
up to date. Clean -j4 builds of tests/kernel, of five regression tests and
of tests' kernel-lib and kernel targets now archive each library once.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parallel test builds raced on the kernel library. Every kernel and regression test links a
sw/kernellibrary, and each test's own Makefile built it on demand.make -jNon a fresh tree, the per-test makes compiled and archived the library concurrently.ar: vx_spawn.c.2.o: No such file).tests/Makefilerunskernelandregressionside by side, so it raced the same way.The fix:
build-%andrun-%intests/kernelandtests/regression, and ofkernelandregressionintests/Makefile.tests/kernelbuilds a missing simulator once, assim-<backend>, before its per-test runs.Impact and evidence
Impact class: R2 (
ci/change_impact.py classify)Contracts touched: none
sw/kernel, each library is archived once by each of:make -j4oftests/kernel all, five regressionbuild-*targets, andtestskernel-lib kernel. Before, it was archived up to four times concurrently.make -n run-simxorders the library and simulator before the per-test runs.model_parityperf_gatelogic_gate🤖 Generated with Claude Code