Repository navigation
Conversation
…es (pytest ci -m perf_gate --update-baselines) and lock in Beacon core area (ci/logic_gate.py -b core --update-baseline)
…/logic_gate.py --tool beacon_asic -b core --update-baseline)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comment: Operand collectors take up a huge amount of logic on the FPGA and area on ASIC at NT=32. But
I also have an LLVM PR if you want to ensure register bank conflcits are rare by design.
vortexgpgpu/llvm#4
The AI-generated body section has evidence of these regression cases not causing any notable performance issue
AI-generated comment:
Summary
One operand collector per issue slice by default (
VX_CFG_NUM_OPCS = 1; it wasup(NUM_WARPS / (4 * ISSUE_WIDTH)), one per 4 warps of a slice, so 4 per slice at 64 warps).The scoreboard already issues only when the target unit's dispatch queue has room (per-FU credits,
VX_scoreboard.sv), so a collector never waits on a busy unit. The only thing extra collectors hide is a register bank conflict, and those stall 0–9% of collector cycles on the kernels below. Each collector holds three full-width operands and its own 4 register-file banks, so the extra collectors cost a lot of area for no cycles.No RTL or SimX code changes: both already take any collector count (warp
wis % NUM_OPCS,sim/simx/operands.cpp). Any config can still ask for more with-DVX_CFG_NUM_OPCS=N.Cycles
rtlsim, XLEN 32, 1 core, 8 SIMT kernels, v3.02 toolchain. Retired instructions are identical in every pair.
64 warps, 4 issue slices, 32 threads (16 collectors → 4):
With the previous toolchain the same sweep is −2.1% geomean, worst +0.8% (sgemv). 2 per slice matches 4 per slice to the cycle on every kernel with both toolchains.
64 warps, 1 issue slice, 8 threads (4 collectors → 1):
dotproduct reports FAIL at 2048 threads under both settings: a float summation-order mismatch in the check (16339.037 vs 16339.059), not a timing effect. Its cycles are valid.
Why fewer collectors is faster is not root-caused; the likely cause is the changed issue order of instructions and memory requests. Nothing measured shows a slowdown that would argue for more than one per slice.
Area
Beacon FPGA
corebuild (16 warps, 16 threads; 4 collectors → 1):Beacon ASIC
corebuild (ASAP7, 8 warps, 8 threads; 2 collectors → 1):The other 13 builds of each Beacon flow pass unchanged.
Impact and evidence
See docs/review/code-review-policy.md.
Impact class: R3 (
ci/change_impact.py: config-knobs, golden-values). No review agent pass has been run on this change.Contracts touched:
config-knobs:pipeline.VX_CFG_NUM_OPCSdefaultup(NUM_WARPS / (4 * ISSUE_WIDTH))→1. No profile or CI case sets the knob, and no doc names its default (docs/designs/mlp_optimizations.mddescribes thewis % NUM_OPCSmapping, which is unchanged). The cases that show the moved default are the perf_gate rows below.golden-values: perf baselines (8 files),ci/baselines/synthesis/beacon/core.jsonandci/baselines/synthesis/beacon_asic/core.json, re-recorded with the commands named in the commit messages:pytest ci -m perf_gate --update-baselinesci/logic_gate.py -b core --update-baselineandci/logic_gate.py --tool beacon_asic -b core --update-baseline(Beacon fails on an improvement beyond its 5% band until re-recorded)Perf baseline deltas. Only 4 of 49 cases moved cycles, all multi-core; the rest changed
config_hashonly.The one value that moved toward a looser bar is
core:sgemm-mc-nt4(+625 cycles, +0.04%), from this commit.model_parityperf_gatelogic_gate(FPGA and ASIC)coreimproved as above and is re-recorded in both.fpga_gate/asic_gate)corebaselines will move (smaller) on the first nightly after merge and need a human--update-baseline.A
not runis not a pass. Say why it was not run.known_issue:, wider tolerance, smaller args, removed case) without a root-cause plan.Notes for review:
feature/register-bank-hints) gains about 1% at 2 or more collectors per slice and nothing at 1. It is not needed for this change and is not part of it.