Skip to content

Delta validity is a top level child - #9970

Open
robert3005 wants to merge 1 commit into
developfrom
fix/fastlanes-delta-validity-top-child
Open

robert3005 wants to merge 1 commit into
developfrom
fix/fastlanes-delta-validity-top-child

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

For performant delta encoding we have to read all the values in deltas
buffer that means that undefined values in deltas buffer are
significant. Instead of performing careful transformation dance to
ensure correctness we remove null values from deltas and keep them as
a top level child. Cascading encodings don't need any special handling
and will preserve all values since they're all valid.

Comment thread encodings/fastlanes/src/delta/array/delta_compress.rs
Comment thread encodings/fastlanes/src/delta/array/delta_compress.rs Outdated
@robert3005
robert3005 force-pushed the fix/fastlanes-delta-validity-top-child branch from f1e55d9 to ef96e92 Compare September 21, 2026 20:00
@robert3005 robert3005 added the changelog/break A breaking API change label Sep 21, 2026
For performant delta encoding we have to read all the values in deltas
buffer that means that undefined values in deltas buffer are
significant. Instead of performing careful transformation dance to
ensure correctness we remove null values from deltas and keep them as
a top level child. Cascading encodings don't need any special handling
and will preserve all values since they're all valid.

Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed

codspeed Bot commented Sep 21, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 11.75%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
❌ 4 regressed benchmarks
✅ 2203 untouched benchmarks
⏩ 293 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation decode_primitives[f32, (1000, 512)] 42 µs 64.2 µs -34.63%
Simulation take_fsl_u32_random[16, 100] 125.9 µs 165.8 µs -24.03%
WallTime dbp_assemble_kernel_avx512[(I128, 1024)] 463 ns 557 ns -16.88%
WallTime dbp_assemble_kernel_avx2[(I128, 1024)] 464 ns 538 ns -13.75%
Simulation take_fsl_f16_random[16, 100] 179.5 µs 119.4 µs +50.35%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix/fastlanes-delta-validity-top-child (2d0a705) with develop (a542cbd)

Open in CodSpeed

Footnotes

  1. 293 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005
robert3005 force-pushed the fix/fastlanes-delta-validity-top-child branch from ef96e92 to 2d0a705 Compare September 21, 2026 20:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant