feat(town): demo folklore tour, roommates, and fullscreen by jack-arturo · Pull Request #11 · verygoodplugins/cottagecode

jack-arturo · 2026-09-22T17:57:46Z

Summary

Expand the demo folklore tour to the full haunt/parcel ladder, with a settled hint and one-time night preview
Agents that share an absolute worktreePath share one cottage plot with cramped roommate sprites
Add townmap fullscreen (Fullscreen API + CSS fallback; button + F / Escape)

Test plan

npm test
Open /?demo=1, toggle settled, confirm Reed/Sable/Moss haunt stages and parcel ladder
Confirm Marge+Otto share one cottage; nameplate shows +1
Click Fullscreen / press F; Escape exits on the townmap

Pin the full haunt/parcel ladder in demo, collapse absolute worktreePath agents onto one cramped cottage, and add stage fullscreen with an F key.

chatgpt-codex-connector · 2026-09-22T17:58:01Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-22T18:35:48.987740Z	`d667786`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 94beb3c0a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Anchor shared worktrees to a stable host id, remap lodger parents so sheds stay attached, and let Escape exit CSS fullscreen without canvas focus.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b66244bc71

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Keep shared-plot hosts on earliest id only, light windows when any roommate works, and keep PR filters matching the whole household.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c0f7c27ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Group roommates from the full feed before settled filtering, surface a blocked roommate on the cottage marker, and ignore bubbled Escape after the canvas already handled it.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6e21c4467e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Key layout slots by worktree plotKey, keep roommate sprites talkable when the host is indoors, and dispatch the household PR that matches the filter.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d667786670

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-22T18:35:46Z

+
+  for (const [key, members] of groups.entries()) {
+    if (members.length === 1) {
+      result.push({ ...members[0], roommates: [], plotKey: "wt:" + key });


Keep plot keys stable when path metadata changes

When a feed first omits worktreePath and supplies it on a later poll, this changes the same agent's key from its ID to wt:<path>; createTownLayout has no slot under the new key and allocates a different position. The reverse happens if the path temporarily disappears, and newly recognized roommate groups likewise move to a third slot instead of reusing a member's existing one. Preserve or alias the prior slot when the grouping key changes so ordinary metadata enrichment cannot move cottages.

AGENTS.md reference: AGENTS.md:L67-L68

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-09-22T18:35:46Z

    ctx.globalAlpha=(filter&&filter!==townKey(p.agent))||!observatory?.visible(p.agent)?0.3:1;
-    observatory?.drawDispatch(ctx,p,t);
-    const bubble=statusBubbleAnchor({agent:p.agent,plot:p,routine:bedtimeFrames.get(p.agent.id),actor:actors.get(p.agent.id),time:t,reduce});
+    observatory?.drawDispatch(ctx,{...p,agent:householdDispatchAgent(p.agent, a=>prStage(a.pr)===observatory.state.prFilter)},t);


Route parcel clicks to the displayed roommate PR

When this selects a roommate's outstanding or filter-matching PR, the parcel is rendered from that roommate, but handleClick() still reads plot.agent.pr and opens or displays the host's PR desk. Thus a visible roommate parcel can open the wrong URL or an empty host desk. Fresh evidence after the earlier thread is that only the drawing path now calls householdDispatchAgent; the click path at observatory.mjs:330-332 still dereferences the host.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-09-22T18:35:46Z

+      // Roommates keep their own outdoor presence even when the host is indoors.
+      const stoopX = a.indoors ? door.x : a.x;
+      const stoopY = a.indoors ? door.y : a.y;
+      (ag.roommates||[]).forEach((mate,i)=>{


Keep roommate targets aligned with bedtime rendering

Once a nonworking host's bedtime routine becomes settled, the enclosing guard at line 1744 skips this roommate-rendering loop, even if a roommate is working. residentTargets() does not consult the bedtime routine and continues exposing the roommate at the stoop, leaving an invisible area that still triggers E/click conversation. Fresh evidence beyond the earlier offline-host case is this independent nighttime routine.settled path; either keep the roommate visible or suppress/move its interaction target with the same predicate.

AGENTS.md reference: AGENTS.md:L70-L71

Useful? React with 👍 / 👎.

jack-arturo · 2026-09-22T18:37:02Z

Babysit stop — `nonconvergent`

Stopped after repeated remediation on the same roommate / shared-plot household mechanism (stable host → plotKey → lighting/filters → presence/PR routing). Five Codex-reviewed heads; open residual P2s are tracked in #12 rather than continuing past the review-window ceiling.

Residual open threads (left for follow-up)

plotKey flip when worktreePath appears late
parcel click still opens host PR desk
bedtime-settled host hides roommate sprites while talk targets remain

Verified

Head: d667786670e5ac2417bff77c54e411af2189b4ae
CI smoke: pass
Size log: start=423 → later heads stayed under 900
@codex review comments this run: 0 (auto-review only)
Agent did not merge

Label → babysit:blocked until a human decides to continue the roommate edge cases in #12 or merge as-is with that follow-up.

chatgpt-codex-connector · 2026-09-22T18:37:12Z

To use Codex here, create an environment for this repo.

The night pass redrew only the host name, so the +N count stayed in dark wood ink and vanished against the blue palette.

feat(town): demo folklore tour, shared-worktree roommates, fullscreen

94beb3c

Pin the full haunt/parcel ladder in demo, collapse absolute worktreePath agents onto one cramped cottage, and add stage fullscreen with an F key.

jack-arturo added babysit:active Babysit agent is actively working this PR babysit:waiting-codex 👀 Codex reviewing current head and removed babysit:active Babysit agent is actively working this PR labels Sep 22, 2026

chatgpt-codex-connector Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread src/roommates.mjs

Comment thread src/town.mjs Outdated

Comment thread src/observatory.mjs

jack-arturo added babysit:active Babysit agent is actively working this PR and removed babysit:waiting-codex 👀 Codex reviewing current head labels Sep 22, 2026

fix(town): keep roommate plots and sheds stable across refreshes

b66244b

Anchor shared worktrees to a stable host id, remap lodger parents so sheds stay attached, and let Escape exit CSS fullscreen without canvas focus.

jack-arturo added babysit:waiting-ci Babysit waiting for CI checks on current head babysit:waiting-codex 👀 Codex reviewing current head and removed babysit:active Babysit agent is actively working this PR babysit:waiting-ci Babysit waiting for CI checks on current head labels Sep 22, 2026

chatgpt-codex-connector Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread src/roommates.mjs Outdated

Comment thread src/town.mjs Outdated

Comment thread src/town.mjs

jack-arturo added babysit:active Babysit agent is actively working this PR and removed babysit:waiting-codex 👀 Codex reviewing current head labels Sep 22, 2026

fix(town): stabilize roommate host and household visibility

9c0f7c2

Keep shared-plot hosts on earliest id only, light windows when any roommate works, and keep PR filters matching the whole household.

jack-arturo added babysit:waiting-codex 👀 Codex reviewing current head and removed babysit:active Babysit agent is actively working this PR labels Sep 22, 2026

chatgpt-codex-connector Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread src/town.mjs Outdated

Comment thread src/town.mjs

Comment thread src/town.mjs Outdated

jack-arturo added babysit:active Babysit agent is actively working this PR and removed babysit:waiting-codex 👀 Codex reviewing current head labels Sep 22, 2026

fix(town): keep shared plots stable when hosts settle

6e21c44

Group roommates from the full feed before settled filtering, surface a blocked roommate on the cottage marker, and ignore bubbled Escape after the canvas already handled it.

jack-arturo added babysit:waiting-codex 👀 Codex reviewing current head and removed babysit:active Babysit agent is actively working this PR labels Sep 22, 2026

chatgpt-codex-connector Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread src/roommates.mjs Outdated

Comment thread src/town.mjs Outdated

Comment thread src/town.mjs

jack-arturo added babysit:active Babysit agent is actively working this PR and removed babysit:waiting-codex 👀 Codex reviewing current head labels Sep 22, 2026

jack-arturo added 2 commits September 22, 2026 20:28

fix(town): persist shared plot slots and household PR/presence

3a8327b

Key layout slots by worktree plotKey, keep roommate sprites talkable when the host is indoors, and dispatch the household PR that matches the filter.

fix(roommates): keep plotKey in scope when collapsing shared plots

18511f2

fix(roommates): keep worktree plotKey when a shared host becomes solo

d667786

jack-arturo added babysit:waiting-codex 👀 Codex reviewing current head and removed babysit:active Babysit agent is actively working this PR labels Sep 22, 2026

chatgpt-codex-connector Bot reviewed Sep 22, 2026

View reviewed changes

jack-arturo mentioned this pull request Sep 22, 2026

Follow-up: roommate household edge cases from PR #11 #12

Open

jack-arturo removed the babysit:waiting-codex 👀 Codex reviewing current head label Sep 22, 2026

jack-arturo added the babysit:blocked Babysit stopped; unresolved blocker needs human label Sep 22, 2026

fix(town): redraw roommate nameplates in the night ink

ec73f7a

The night pass redrew only the host name, so the +N count stayed in dark wood ink and vanished against the blue palette.

jack-arturo merged commit a1825bf into main Sep 22, 2026
1 check passed

jack-arturo removed the babysit:blocked Babysit stopped; unresolved blocker needs human label Sep 22, 2026

Conversation

jack-arturo commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

chatgpt-codex-connector Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

jack-arturo commented Sep 22, 2026

Babysit stop — nonconvergent

Residual open threads (left for follow-up)

Verified

Uh oh!

chatgpt-codex-connector Bot commented Sep 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jack-arturo commented Sep 22, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 22, 2026 •

edited

Loading

Babysit stop — `nonconvergent`