Skip to content

chat: accept the super reasoning effort - #23

Merged
natcale merged 1 commit into
mainfrom
chat/super-effort
Oct 13, 2026
Merged

natcale merged 1 commit into
mainfrom
chat/super-effort

Conversation

@natcale

@natcale natcale commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Session state now uses the same reasoning-effort union as the composer, including super.
  • This is the type error that failed the v1.0.3 Windows installer build.

Test plan

  • npx tsc --noEmit
  • npm run test:all (476 Vitest, 210 Rust)
  • CI Test on this PR

Summary by CodeRabbit

  • Chores
    • No user-visible changes. The available reasoning effort options and default setting remain unchanged.

The composer can select super, but session state only allowed low through max, so the 1.0.3 installer build failed typecheck.
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: useshape/Shape/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a32b9b49-5564-438c-af42-7ae41de407fb
📥 Commits

Reviewing files that changed from the base of the PR and between c465393 and d28d13e.

📒 Files selected for processing (1)
  • features/chat/lib/use-chat-session.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The chat session hook now uses the imported ReasoningEffort type for persisted composer preferences and state. The accepted values and the "low" default remain unchanged.

Changes: Chat reasoning effort typing

Layer / File(s) Summary
Use the shared reasoning-effort type
features/chat/lib/use-chat-session.ts
ComposerPrefs.effort and reasoningEffort now use the imported ReasoningEffort type. The local and inline unions are removed. The "low" default remains unchanged.

Priority: ⬆️ High

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to d28d1

This aligns session typing with the composer’s existing super option without changing the default or model fallback behavior. No actionable merge risk is identified.

Pre-merge checks · Passed 4 · Failed 1

Failed Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks (4 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: allowing the chat session to accept the super reasoning effort.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Comment @coderabbitai help to get the list of available commands.

@natcale
natcale merged commit 322e9f7 into main Oct 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant