fix: complete persistent flags in shell completion - #2437
Open
sb123sb123 wants to merge 1 commit into
Open
sb123sb123 wants to merge 1 commit into
sb123sb123 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2173.
When shell completion runs for a subcommand,
DefaultCompleteWithFlagspassed only the command's local flags to the suggestion formatter. Persistent flags defined by an ancestor command are still valid after entering the subcommand, but they were omitted from suggestions, so a prefix such as--confcould not complete to--config.This change combines visible persistent flags with the command's visible local flags before generating suggestions. The regression test covers a persistent string flag before and after a positional argument, plus the short
-prefix used by zsh completion. Existing completion fixtures now mark their intentionally command-local flags withLocal: true.Testing
go test . -count=1 -run TestCompletionIncludesPersistentFlagsAfterPositionalArgumentgo test . -count=1 -run TestPartialFlagCompletionAfterPositionalArgumentgo test . -count=1 -run TestDefaultCompleteWithFlagsgo test ./... -count=1go vet ./...gofmtchecks andgit diff --checkLimitations
proxy.golang.org; the successful test runs used the existing local module cache withGOPROXY=off.gccis unavailable.golangci-lint,staticcheck,goimports, andgfmrunwere not installed on the host.AI assistance disclosure
This pull request was developed with assistance from OpenAI Codex. The submitting operator reviewed and understood the implementation, tests, verification results, and this description.
Release Notes