Repository navigation
fix: stop forwarding --debug to the legacy CLI - #208
Closed
pjcdawkins wants to merge 4 commits into
Closed
pjcdawkins wants to merge 4 commits into
pjcdawkins wants to merge 4 commits into
Conversation
The root command's persistent --debug flag was passed through to the
legacy PHP CLI, which rejected it ("The "--debug" option does not
exist."). Strip it before the args are forwarded, in the root command
and in both help paths, and pass debug mode to the legacy CLI as
<PREFIX>DEBUG=1 instead, matching the environment variable.
The help command does not parse flags, so it now enables debug mode
itself when --debug is given.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Otherwise an inherited <PREFIX>DEBUG=1 still enables PHP debug output when --debug=false is given. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The help command does not parse flags, so an explicit false value must also override <PREFIX>DEBUG. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Upsun Dispatch™ — this review was canceled. No review was posted for this update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root command's persistent
--debugflag was passed through to the legacy PHP CLI, which rejected it:upsun cc --debugprintedThe "--debug" option does not exist.and exited 1.--debug/--debug=<bool>(before any--) when forwarding args to the legacy CLI: in the root command, the root help function, and thehelpcommand.<PREFIX>DEBUG=1(or0), so--debugbehaves like the environment variable, and--debug=falseoverrides an inherited value.helpcommand does not parse flags, so it now applies--debugitself._completestill forwards its words unchanged.🤖 Generated with Claude Code