Repository navigation
fix(installer): point the CLI introduction link at the docs anchor - #207
Merged
Merged
Conversation
The link at the end of a successful install pointed to /get-started/introduction.html#cli, which now redirects to a 404 on the new docs site. Use the /anchors/cli/ URL, which redirects to the current CLI page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![upsun-dispatch[bot]](https://avatars.githubusercontent.com/in/4153575?s=60&v=4){kind=small}
There was a problem hiding this comment.
Warning
Changes suggested — 🟡 1 warning
🔍 Full review · 1 file reviewed
Verification
docs_urlis hard-coded tohttps://docs.upsun.comat installer.sh line 48, so the new link expands to exactlyhttps://docs.upsun.com/anchors/cli/.- The new URL matches the
homepagevalue used three times in .goreleaser.yaml, so installer and package metadata now point to the same place. - The edited line keeps the existing
outputcall shape with no style argument, the same as before the change.
No test covers installer.sh output. The change is a single string edit, and I couldn't confirm the URL's redirect target because the sandbox has no network access to docs.upsun.com.
Review details
- Commit: a17886b
- Model: claude-opus-5-5
Review 1 of 10 for this pull request · View the full run
The old /administration/cli.html path still redirects to the CLI page, but the anchor URL is the stable one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
📋 PR Summary This PR updates the documentation links that the bash installer prints so they use the Changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a successful install, the bash installer prints a "CLI introduction" link to
https://docs.upsun.com/get-started/introduction.html#cli. That URL now redirects to a 404 on developer.upsun.com.This PR changes it to
https://docs.upsun.com/anchors/cli/, which redirects to the current CLI page. It's the same URL the npm package metadata already uses. It also switches the "Read the docs" link shown when an install fails to the same anchor. That link's old URL,/administration/cli.html, still redirects to the CLI page, but the anchor URL is meant to stay stable.🤖 Generated with Claude Code