fix(update): wait briefly for the background update check before exiting

[pjcdawkins]

The update check runs in a background goroutine. Short commands such as --version exited before it could save its result to state.json, so the check was lost.

• Decide synchronously whether a check is due (internal.StartUpdateCheck), and only then start it in the background.
• Before exiting, wait up to 1 second for a running check: after the command, in exitWithError, and after --version (the check now starts before --version is handled). The wait only happens when a check is due, which is at most once per check interval (1 hour by default).
• Record LastChecked before the request starts, so a slow or blocked network costs the wait at most once per check interval.
• Add a 5 second timeout to the GitHub request.
• Drop the unused version comparison from the check; the notice compares versions when it reads the cached result.

Verified by running upsun --version in a PTY with an empty home: main writes no state, this branch records the latest version.

🤖 Generated with Claude Code

[upsun-dispatch]

Warning

Changes suggested — 🟡 1 warning

🔍 Full review · 4 files reviewed

Verification

• state.Update holds a package mutex while it reloads the file, so MarkNotified running alongside the new goroutine cannot drop each other's fields.
• UpdateCheck.Wait handles a nil receiver, so waitForUpdateCheck is safe on completion paths, help paths and paths where no check was started.
• The removed CheckForUpdate has no remaining callers in the Go code.
• StartUpdateCheck keeps the GitHubRepo != "" gate (through shouldCheckForUpdate) that the old call got from its enclosing if block.

The new TestUpdateCheckWait covers only the nil, finish and timeout cases of Wait. No test covers StartUpdateCheck, the root-command wiring, or what happens when the GitHub request runs longer than the wait. The CI test/lint jobs (make test / make lint) cover these files only to that extent.

Review details

• Commit: 7038fcf
• Model: claude-opus-5-5

---

Review 1 of 10 for this pull request · View the full run

[upsun-dispatch]

Warning

Changes suggested — 🟡 1 warning

🔁 Incremental · 1 file reviewed

Verification

• LastChecked is now written synchronously, before the goroutine starts, so a request that outlives the process no longer leaves the check due on the next run.
• The background state.Update now sets only KnownLatestVersion, and only when the release lookup succeeds with a non-empty tag, so a failed lookup no longer touches the cached version.
• state.Update reloads the state under a mutex, so the background write of KnownLatestVersion cannot drop the LastChecked or LastNotified written on the main goroutine.

No test in this increment covers the new ordering: nothing asserts that LastChecked is saved before the request, or that a failed request leaves KnownLatestVersion alone. The repository's Go test job (make test) runs only the existing state and notification tests.

Review details

• Commits: 7038fcf..4231c03
• Model: claude-opus-5-5

---

Review 2 of 10 for this pull request · View the full run

Superseded: the latest Upsun Dispatch review no longer requests changes.