Repository navigation
fix(scoop): drop the vcredist dependency and document the Git requirement - #204
pjcdawkins wants to merge 1 commit into
Conversation
…ment The Scoop manifests depended on extras/vcredist2022, so `scoop install` failed unless the extras bucket had been added. The dependency dates from the official PHP builds; the static-php-cli build used since then imports only Windows system DLLs. Verified on a clean Windows 11 VM: the CLI runs PHP (including curl and OpenSSL) with no Visual C++ runtime installed, and installs from a manifest without the dependency. Scoop also needs Git to add a bucket, which the README did not mention. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![upsun-dispatch[bot]](https://avatars.githubusercontent.com/in/4153575?s=60&v=4){kind=small}
There was a problem hiding this comment.
Warning
Changes suggested — 🟡 1 warning
🔍 Full review · 2 files reviewed
Verification
- No other file in the repo mentions vcredist, VCRUNTIME or extras/ as a Windows PHP dependency, so removing it from both scoop entries leaves no stale references.
- Both
dependsblocks are removed cleanly; theplatformandupsunscoop entries still have the same keys (repository, ids, directory, homepage, description, license). - The Windows PHP binary comes from upsun/cli-php-builds (
php-$(PHP_VERSION)-windows-amd64.exein the Makefile), which matches the PR's claim that it is a static-php-cli build.
No test in the repo covers the generated Scoop manifest. The Makefile's goreleaser check target only checks that the config is valid YAML for goreleaser, and whether PHP runs without the VC++ runtime rests on the author's manual test on a clean Windows 11 VM.
Review details
- Commit: 6e4501e
- Model: claude-opus-5-5
Review 1 of 10 for this pull request · View the full run
|
|
||
| ```console | ||
| scoop install git | ||
| scoop bucket add upsun https://github.com/upsun/homebrew-tap.git |
There was a problem hiding this comment.
🟡 Warning — Users on fresh Windows still fail the install until the next release.
The README on main is what users read, and it now lists only scoop install git, scoop bucket add upsun … and scoop install upsun. The published manifest in upsun/homebrew-tap still has depends: extras/vcredist2022 until the next release regenerates it, and the PR description says so too. Until then, a user on a fresh Windows machine who follows these steps still gets "Couldn't find manifest for 'vcredist2022' from 'extras' bucket", the second failure this PR describes. Either merge this README change together with the release, or add scoop bucket add extras for now.
This branch has not been deployed
1 participant
On a fresh Windows 11, the README's Scoop instructions failed twice:
scoop bucket add upsun …fails with "Git is required for buckets".scoop install upsunfails with "Couldn't find manifest for 'vcredist2022' from 'extras' bucket".This PR removes the
extras/vcredist2022dependency from both Scoop manifests. It was added for the earlier PHP builds. The static-php-cli build now used imports only Windows system DLLs: it has noVCRUNTIME140,MSVCP140orapi-ms-win-crt-*imports. On a clean Windows 11 VM with no Visual C++ runtime installed:dependsremoved works without theextrasbucket.The README now includes
scoop install git.The manifest change applies from the next release. Until then, the current manifest still requires the
extrasbucket.🤖 Generated with Claude Code