Repository navigation
Conversation
cnihelton
marked this pull request as ready for review
October 26, 2026 19:11
This avoids issues with PRs coming from forks with legitimate code changes that demand running the end-to-end tests.
cnihelton
force-pushed
the
fork-friendly-ci
branch
from
October 26, 2026 19:23
b362aeb to
51c8c9d
Compare
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified in the reviewed workflow changes.
No open issues 🎉
What changed in this PR
Updates CI workflows to support forked pull requests while aligning draft-build and E2E execution criteria.
Changes:
- Runs lightweight builds for draft pull requests while limiting E2E jobs to ready pull requests.
- Skips signing requirements for forked builds.
- Provisions a temporary self-signed certificate for E2E package installation.
| File | Description |
|---|---|
.github/workflows/e2e.yaml |
Updates triggers, skips draft runs, and provisions a temporary trusted certificate. |
.github/workflows/build-pr.yaml |
Enables draft builds and conditionally skips certificate installation and package signing for forked pull requests. |
Review effort: Lite
hk21702
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the criteria with which both
e2e.yamlandbuild-pr.yamljobs run. The latter is a slightly lighter job, thus it makes more sense to run it even when PRs are in draft while the other is heavier, thus it should only run when flagged as ready.Most importantly, this PR makes PRs coming from forks no longer need to interact with signing certificates. For
build-pr.yamlit means skipping the package signing part. Fore2e.yamlit means always provisioning a fresh cert - for all PRs, not only forks.