Repository navigation
Conversation
The glb and gltf export formats passed model URLs straight to the GLB converter, which fetch()es them, so a relative cadModel stepUrl such as ./libraries/cap.step failed with 404. They now go through convertModelUrlsToFileUrls like `tsci build --glbs` does. Fixes #5654. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PiJ1d34GaQJAWypDADnioN
…ative-step # Conflicts: # tests/cli/export/export-glb-relative-step-model.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: 2/2, #5875, the repro → this fix. Merge this into the repro branch first, then merge #5875 to
main.Fixes #5654.
Cause
tsci build --glbspasses Circuit JSON throughconvertModelUrlsToFileUrlsbefore callingconvertCircuitJsonToGltf. That turns a relative model path like./libraries/cap.stepinto afile://URL the converter canfetch().tsci export(lib/shared/export-snippet.ts) skipped that step for theglbandgltfformats. The converter received the bare relative path, and the fetch failed with404 Not Found.Change
The
glbandgltfexport branches now callconvertModelUrlsToFileUrls(circuitJson)too, using the same helperbuild-glbs.ts,render-drawing-pages.tsandrender-explosion-video.tsalready import.Result
The repro test is unchanged. Its snapshot of
Failed to load STEP from …messages goes from one entry to[].Checked by hand with
bun cli/main.ts exporton the repro's project:tsci export -f glbtsci build --glbstsci export -f gltfThe CLI test fixture can't run in my container, which has no IPv6 listen, so CI runs the test.
Generated by Claude Code