Repository navigation
Name a session's missing directory instead of blaming the agent - #24
Merged
Merged
Conversation
A session whose directory had gone failed to start with "fork/exec <agent path>: no such file or directory", which reads as a missing executable. pty.StartWithSize sets SysProcAttr, and with it set os.StartProcess skips its own check of the directory, so the failed chdir in the child is reported against the program's path. Start now checks the directory first and reports "start <agent>: session directory: stat <dir>: no such file or directory".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A session whose directory had gone failed with
fork/exec <agent path>: no such file or directory, which reads as a missing executable.pty.StartWithSizesetsSysProcAttr, and with it setos.StartProcessskips its own directory check (Go 1.26.4os/exec_posix.go:27-36), so the failed chdir is reported against the program's path.Startnow checks the directory first. The new test reproduces the old message with the check removed.