Repository navigation
Put AppendNote's doc comment back on AppendNote - #23
Merged
Merged
Conversation
The comment sat above the compactAbove and keepNotes block, so Go took all of it as the constants' documentation and AppendNote had none. The sentences about trimming stay on the constants they describe, and the ones about appending move down to the function. No wording changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment sat above the
compactAbove/keepNotesblock, so Go attached all of it to the constants andAppendNotehad no documentation. The trimming sentences stay on the constants, and the appending sentences move to the function. No wording changes.