Repository navigation
Ask before quitting while an agent is running - #18
Merged
Merged
Conversation
The picker.go header called the list filterable, and picker.update has no filter. Both picker file headers also counted the kinds the modal serves, and that number was already stale. The headers now say what the files hold without a count. pickerKey's comment named only the theme picker, though it routes a key to every kind. Comments only.
The agents are Deck's children, so quitting stops every one of them, and q or ctrl+c did that without a word. Every quit key (q, ctrl+c, ^g q) now goes through requestQuit. It quits at once when no agent is running, and otherwise asks. The cursor opens on the row that loses nothing, so q and a reflexive ↵ keep every agent. Quit is one row down and says how many agents it stops. Inside tmux the safe row is Detach tmux, which runs tmux detach-client: Deck and its agents keep running, and tmux attach resumes them. Outside tmux it is Stay. The row is not called "Detach" alone, because ^g esc already detaches the keyboard from the pane. A failed detach is reported, not swallowed. The modal is the one x already uses to end a session, and its footer now says "choose" instead of "apply", which read oddly on a question. The smoke test answers the new question. README and architecture describe it, with the tmux recipe for running Deck on a server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quitting Deck stops every agent it hosts, and
qorctrl+cdid that without asking.q,ctrl+cand^g qnow ask while an agent is running. With none running, Deck quits at once.qthen↵keeps every agent.tmux attachresumes them. Outside tmux it is Stay.tmux detach-clientis reported.Two commits: the first changes comments only (the picker headers claimed a filter that does not exist), the second is the behaviour.
Checked by hand in a real tmux: Detach tmux disconnects the client while Deck and a bash agent keep running, reattaching shows the same session, and Quit ends Deck. With two clients attached, only the one that typed is disconnected.