Skip to content

fix(benchmark): leave unjudged worklist validity unanswered - #115

Open
chubirka wants to merge 1 commit into
developmentfrom
fix/unjudged-worklist-validity-qjd5zssc
Open

chubirka wants to merge 1 commit into
developmentfrom
fix/unjudged-worklist-validity-qjd5zssc

Conversation

@chubirka

Copy link
Copy Markdown
Member

Classifier plan 05 — validity on unjudged worklists

Target development, not main. Required reviewer @smith-xyz; keep a merge hold and no auto-merge.

The finite writer-inventory reconciliation found that the reachable validation-benchmark plan emits deprecated validity.not_verified as findings[].validation_status. These fixture claims are not judgments. Remove that source label; do not replace it with confirmed, null against an unrelated schema, or an invented evidence grade.

The existing validation JSON parser does not consume this field. Actual planned claims normalized identically with and without the legacy label. This changes only an unjudged harness-QA worklist, not audit-report validation policy, a canonical Decision, historical reports, cluster execution or scanner results.

Verification

  • New benchmark-output regression failed before and passed after.
  • Engine lint/format and full non-integration suite: 452 passed, 4 skipped, 5 subtests passed.
  • RELEASE_BASE=origin/development make check-release passed; patch metadata 0.39.4, no tag/release created.
  • Actual frozen App CLI sweep benchmark --benchmark-dir <temporary fixture copy> plan executed the installed Engine candidate, emitted four unjudged claims and no validity label. Existing consumer normalization was unchanged relative to the legacy input.
  • Paired App cleanup also omits the same obsolete field from cluster-drift candidates; actual module CLI and parser equivalence passed. No cluster command was executed.

Scope is this confirmed reachable repair only. The checklist separately retains real audit no-answer/validator, triage-kind representation and SDK legacy-wire owner gaps. This PR does not claim that the complete validity-family or plan05 rollout is closed. Existing test expectations were not changed.

@chubirka
chubirka requested a review from a team as a code owner October 27, 2026 21:17
@openshift-ci

openshift-ci Bot commented Oct 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chubirka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2026
@chubirka
chubirka requested a review from smith-xyz October 27, 2026 21:18
@chubirka chubirka added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2026
@chubirka

Copy link
Copy Markdown
Member Author

Paired App repair/adoption: traust-security/traust#295, exact App candidate 609a5a4cc5ea77b3c99d05daed93ef9bfcf131c8. It pins Engine 5bd3ae9 and removes the same obsolete validity label from cluster-drift claims. Both actual installed CLI commands and the existing validation parser passed; Engine suite 452 passed/4 skipped plus 5 subtests, App PostgreSQL-enabled suite 2652 passed/2 skipped. Merge Engine #115 first, then App #295 after Shaun review; holds remain and no auto-merge is enabled. The finite inventory closeout separately records remaining audit-report, triage-source and SDK compatibility gaps; these two reachable worklist fixes do not claim whole-family closure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant