Repository navigation
Conversation
nfebe
force-pushed
the
feat/optional-ui-plugin-layers
branch
from
October 20, 2026 21:35
eacbb7e to
cb30023
Compare
Deploying trakli-dev with
|
| Latest commit: |
cb30023
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4d3ce8c2.trakli-dev.pages.dev |
| Branch Preview URL: | https://feat-optional-ui-plugin-laye.trakli-dev.pages.dev |
Deploying webui with
|
| Latest commit: |
cb30023
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8a3ac5cd.webui-9fh.pages.dev |
| Branch Preview URL: | https://feat-optional-ui-plugin-laye.webui-9fh.pages.dev |
Code Review SummaryNuxt config now extends optional UI plugin layers listed in 🚀 Key Improvements
💡 Minor Suggestions
|
| continue; | ||
| } | ||
|
|
||
| const href = ui.onboarding?.href || ui.card?.href; |
There was a problem hiding this comment.
|| takes the first present href, so a contribution is gated on onboarding.href even when the card's own card.href route exists (and vice versa). A working link then disappears from a slot. Check every local href and skip only when none resolve.
Suggested change
| const href = ui.onboarding?.href || ui.card?.href; | |
| const localHrefs = [ui.onboarding?.href, ui.card?.href].filter( | |
| (href): href is string => typeof href === 'string' && href.startsWith('/') | |
| ); | |
| if (localHrefs.length && localHrefs.every((href) => !router.resolve(href).matched.length)) { | |
| continue; | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load optional pages and translations from installed plugin layers. Hide integration links when their pages are absent.