Repository navigation
feat: add composable fixture lifecycle plugins - #16
Merged
Merged
Conversation
Compose fixture setup and teardown through plugins. Wait for pending filesystem operations before cleanup and document plugin instance scope. Based on #15 by @GiHoon1123. Co-authored-by: GiHoon1123 <rlaejrqo465@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add composable lifecycle plugins to
Fixture.createandFixture.fromDirectory. Setup runs in declaration order after files are prepared; teardown runs in reverse order before directory removal, including after partial setup failure.Repeated or concurrent cleanup shares one operation. Teardown failures do not prevent remaining cleanup, and initialization and cleanup errors are preserved.
Wait for pending filesystem operations before cleaning up a failed fixture to prevent delayed writes from racing directory removal. Document per-fixture instances for plugins that store mutable state.
Based on #15 by @GiHoon1123 , who is credited as a co-author of the squashed commit.
Closes #15
Closes #14
Checklist
README.mdandREADME.ko.mdare updated, if user-facing behavior changed.yarn changeset), if the published package changed.