Skip to content

Add a typed SSH userauth mode to tk ssh agent - #116

Draft
emostov wants to merge 5 commits into
mainfrom
zeke/typed-ssh-userauth
Draft

emostov wants to merge 5 commits into
mainfrom
zeke/typed-ssh-userauth

Conversation

@emostov

@emostov emostov commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

tk ssh agent signs SSH logins as raw payloads, so Turnkey policy cannot see which server a login is for. A new typed mode sends each login with its session-bind@openssh.com message to Turnkey's SIGN_SSH_USERAUTH activity, which verifies the host before policy runs.

Public API changes

  • New tk ssh agent start --userauth typed|raw (default raw); agent status reports userauth.
  • New tk ssh github-host-keys, which prints GitHub's host key fingerprints from api.github.com/meta.

Review packet: https://reviews.figitaki.dev/r/tK4TCrx6

Review focus

  • Typed mode never falls back to raw signing; it refuses logins without a matching bind or through a forwarded agent.
  • A temporary [patch.crates-io] points turnkey_* 0.16 at a rust-sdk branch that adds the activity to 0.16 (the change for main is Add the SIGN_SSH_USERAUTH activity to the client rust-sdk#327); replace it with a release before merge.
  • Typed mode refuses host key types Turnkey does not verify.

Testing

Added unit and e2e tests.

AI usage

Implemented with AI (Claude Opus 5.5) using the ship-loop skill

emostov and others added 5 commits November 13, 2026 14:22
…gh Turnkey's SIGN_SSH_USERAUTH activity, plus tk ssh github-host-keys.

Co-authored-by: Turnkey <noreply@turnkey.com>
… e2e test for tk ssh github-host-keys.

Co-authored-by: Turnkey <noreply@turnkey.com>
…nkey does not verify, and drop internal remarks from docs and tests.

Co-authored-by: Turnkey <noreply@turnkey.com>
…uplicate GitHub host key formatting.

Co-authored-by: Turnkey <noreply@turnkey.com>
… that adds SIGN_SSH_USERAUTH.

Co-authored-by: Turnkey <noreply@turnkey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant