Repository navigation
Conversation
…gh Turnkey's SIGN_SSH_USERAUTH activity, plus tk ssh github-host-keys. Co-authored-by: Turnkey <noreply@turnkey.com>
… e2e test for tk ssh github-host-keys. Co-authored-by: Turnkey <noreply@turnkey.com>
…nkey does not verify, and drop internal remarks from docs and tests. Co-authored-by: Turnkey <noreply@turnkey.com>
…uplicate GitHub host key formatting. Co-authored-by: Turnkey <noreply@turnkey.com>
… that adds SIGN_SSH_USERAUTH. Co-authored-by: Turnkey <noreply@turnkey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tk ssh agentsigns SSH logins as raw payloads, so Turnkey policy cannot see which server a login is for. A new typed mode sends each login with itssession-bind@openssh.commessage to Turnkey'sSIGN_SSH_USERAUTHactivity, which verifies the host before policy runs.Public API changes
tk ssh agent start --userauth typed|raw(defaultraw); agent status reportsuserauth.tk ssh github-host-keys, which prints GitHub's host key fingerprints fromapi.github.com/meta.Review packet: https://reviews.figitaki.dev/r/tK4TCrx6
Review focus
[patch.crates-io]pointsturnkey_*0.16 at a rust-sdk branch that adds the activity to 0.16 (the change for main is Add the SIGN_SSH_USERAUTH activity to the client rust-sdk#327); replace it with a release before merge.Testing
Added unit and e2e tests.
AI usage
Implemented with AI (Claude Opus 5.5) using the ship-loop skill