Repository navigation
Conversation
Move kebab-case enum parsing into enum_args so private-key and wallet commands accept the same spellings. The variant list now fails to compile when the API adds a variant. Group the single-key flags in one optional struct, so a name without a curve cannot reach command code. Say that --tag takes a private key tag. Build the query client once. Drop the mock pending test, which the live suite covers. Co-authored-by: Turnkey <noreply@turnkey.com>
Use the plain path for ALL in the enum macro, rename its test to what it checks, and label the multi-key example in the resources doc. Co-authored-by: Turnkey <noreply@turnkey.com>
emostov
reviewed
Nov 6, 2026
Collaborator
There was a problem hiding this comment.
Eventually we might want to see if we can just import these from rust-sdk, but good enough for now
emostov
reviewed
Nov 6, 2026
Collaborator
There was a problem hiding this comment.
Just do these as e2e tests, if you need to iterate push to CI. If you can't produce the failures from live API then you shouldnt need to test it
emostov
reviewed
Nov 6, 2026
emostov
left a comment
Collaborator
There was a problem hiding this comment.
The CLI api LGTM 👍
Just would prefer to not have tests that need mocks
Also double check if we can easily import address type enum from rust-sdk, if not, no worries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
tk private-keycommand group for Go CLI (turnkey private-keys) parity.list(get_private_keys) andget --id(get_private_key; a missing key isnot_found).createfrom flags (--name,--curve, repeatable--address-format, repeatable--tagID) or--input-json/--input-file(CreatePrivateKeysIntentV2). It goes throughsubmit_activity, sopendingand consensus-needed behave likewallet create.--address-formataccepts only the short kebab form (ethereum,bitcoin-mainnet-p2pkh) with the possible values exposed to clap. The parser is local toprivate_keys.rs. Add flag-based input to wallet and sign commands #112 adds case-insensitive, prefix-optional enum parsing for wallets; the two should converge later.privateKeyTagsis now ID-normalized in JSON input, so malformed tag IDs fail asinvalid_inputbefore credentials load.docs/commands.md; added a section todocs/resources.md; addedprivate-keyto the cli-convention command list.ssh/keys.rsis untouched: its helpers are Ed25519-specific.Tests:
tests/e2e/private_keys.rs(create, get, list, multi-key--input-json). It compiles under clippy/cargo test --no-runbut was not run live (no.env.test).tests/private_keys.rs(wiremock) is limited to what the live API can't produce on demand: absent key ->not_found, consensuspending(exactparameters,type,organizationId), exit 2 usage error, invalid local input.src/private_keys.rs.cargo fmt --check,clippy -D warnings,cargo docpass.cargo testpasses except the pre-existingoperations::tests::mutation_timeout_is_unknown_and_does_not_leak_bodytiming flake (also fails on main).