Fix dataset display labels to reflect dataset kind - #63
Merged
Merged
Conversation
snamber
force-pushed
the
fix/dataset-kind-display
branch
from
October 4, 2026 01:54
6c458f1 to
7eacbee
Compare
Preserve AnnotatedType kind metadata and use it in both client representations. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a10420-0f3b-74bc-a0e1-29880126b319
snamber
force-pushed
the
fix/dataset-kind-display
branch
from
October 4, 2026 01:57
7eacbee to
d0aa8ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Both sync and async DatasetClient representations now display Temporal Dataset or Spatiotemporal Dataset based on the kind returned by the API. Unspecified kinds use Dataset rather than guessing.
The API already returns AnnotatedType.kind, but the Python model discarded it. Preserve that metadata in both protobuf conversion directions, with a default of None to retain compatibility with existing constructors.
This fixes the misleading Timeseries Dataset label observed in the s2-sen2cor example. Dataset creation and geometry ingestion are unchanged; no schema or generated-code changes are needed.
Verification