Skip to content

Add storage location and notification subscription API - #77

Merged
lukasbindreiter merged 1 commit into
mainfrom
storage-triggers
Oct 2, 2026
Merged

lukasbindreiter merged 1 commit into
mainfrom
storage-triggers

Conversation

@snamber

@snamber snamber commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Separate storage management from AutomationService into StorageLocationService and storage_location.proto.

Add typed provider references, location rename, SNS/Pub/Sub/Event Grid subscriptions, and location-scoped event history with descending pagination and triggered job/automation IDs. Azure delivery secrets are returned only on creation. StorageLocation.reference remains optional for legacy automation requests; CreateStorageLocationRequest requires it.

Compatibility notes:

  • Existing storage field numbers and provider enum numbers are preserved.
  • The approved enum renames GCS → GCS_BUCKET, S3 → AWS_S3_BUCKET, and FS → FILESYSTEM are JSON/source compatibility breaks. Buf WIRE_JSON breaking reports these three changes; no override has been applied.
  • Storage RPCs move from AutomationService to StorageLocationService. The pending Core implementation retains legacy route aliases, but does not translate the old CreateStorageLocation request payload.

Validation: Buf 1.73.0 format, lint, and build pass; git diff --check passes. Core clients were regenerated and tested locally.

Rollout: merge and publish this API first. Core dependency updates and its PR will follow only after publication is confirmed. No Core PR or deployment is included here.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Lint Protobuf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedOct 2, 2026, 12:15 PM

@lukasbindreiter lukasbindreiter added the buf skip breaking This is a breaking change label Oct 2, 2026
@lukasbindreiter
lukasbindreiter merged commit 5149636 into main Oct 2, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buf skip breaking This is a breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants