Repository navigation
Conversation
👷 Deploy request for calico-docs-preview-next pending review.Visit the deploys page to approve it
|
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The documentation contains an unresolved inconsistency about whether --network-policy none yields networkPolicy: null or "none", leaving the supported value and verification guidance unclear in both affected files.
2 open issues
What changed in this PR
Updates Calico Cloud AKS system requirements to recommend disabling AKS-managed network policy and warn about the operational risks of using Azure-managed Calico.
Changes:
- Recommends creating AKS clusters with
--network-policy none. - Marks
networkPolicy: "calico"as supported but not recommended. - Adds warnings about AKS-managed Calico resources, migration downtime, and temporary loss of policy enforcement.
| File | Description |
|---|---|
| calico-cloud/get-started/system-requirements.mdx | Updates the current Calico Cloud AKS requirements with network-policy recommendations and migration warnings. |
| calico-cloud_versioned_docs/version-24-1/get-started/system-requirements.mdx | Applies the same AKS network-policy guidance and migration warnings to the version 24.1 documentation. |
Review effort: Lite
Comment on lines
+147
to
+148
| We recommend that `networkPolicy` is `null`. | ||
| To get this, create your cluster with `--network-policy none`. |
Comment on lines
+147
to
+148
| We recommend that `networkPolicy` is `null`. | ||
| To get this, create your cluster with `--network-policy none`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Calico Cloud system requirements page now recommends
--network-policy noneon AKS. It also warns about clusters made with--network-policy calico.Jira: https://tigera.atlassian.net/browse/DOCS-3167
Preview: https://deploy-preview-3213--calico-docs-preview-next.netlify.app/calico-cloud/get-started/system-requirements#azure-kubernetes-service
Flags:
--network-policy calicostill supported for new installs? This PR marks it "not recommended".--network-policy none, doesaz aks showreportnullor"none"? The page saysnull.