Skip to content

audio: mfcc: validate config blob size before use #11270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shrusti-pk wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

audio: mfcc: validate config blob size before use #11270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/audio/mfcc/mfcc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,11 @@ static int mfcc_prepare(struct processing_module *mod,

cd->config = comp_get_data_blob(cd->model_handler, &data_size, NULL);

/* Initialize MFCC, max_frames is set to dev->frames + 4 */
if (cd->config && data_size > 0) {
/* Initialize MFCC, max_frames is set to dev->frames + 4. The blob is
* dereferenced as a struct sof_mfcc_config below, in mfcc_setup() and
* in the processing code, so require it to be at least that large.
*/
if (cd->config && data_size >= sizeof(struct sof_mfcc_config)) {
ret = mfcc_setup(mod, dev->frames + 4, audio_stream_get_rate(&sourceb->stream),
audio_stream_get_channels(&sourceb->stream));
if (ret < 0) {
Expand Down