Repository navigation
The tests of the facade, one behaviour each (OIL 41, Testing.md) - #150
Merged
Merged
Conversation
test/MaxMatrixTest.cpp brought to the rules of Testing.md that review checks: - the tests of Batch have a file of their own, test/MaxMatrixBatchTest.cpp, as their header has (TS-5); what a test saw inside a block is asserted after it (TS-10); - a test that drew in both modes, those of the shutdown and of the display test, and the tests of the pace of a shift are split into one behaviour each (TS-9), the pace's on a fixture that starts the shift; - a register of every chip is compared with a vector written down rather than looped over (TS-13, TS-14), through ChipValues() of the test support; - the tests of a matrix not set up share a fixture of their own, rather than making one beside the fixture's, whose check after the test then compared what no test had drawn (TS-17); - a test that leaves the LEDs other than the buffer, as one in shutdown, puts them back at its end, with the reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for a user
Nothing: only the tests of the facade change.
Why
OIL 41, the chapter Tests: each test file is brought in turn to the rules of
docs/Testing.mdthat review checks. This one istest/MaxMatrixTest.cpp.What changed
How it was checked
make checkpasses, with coverage at 100 % of lines, branches and conditions. Flash and RAM of the examples are unchanged.