Repository navigation
Change check_etag default to False - #5
Merged
Merged
Conversation
This project is intended to be used on immutable files, and the check was for extra safety. However, the CDN used by files.pythonhosted.org does not return consistent etags for range requests, and this ended up being something that I would override every time I used this library. It's now opt-in.
thatch
marked this pull request as ready for review
April 25, 2026 22:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project is intended to be used on immutable files, and the check
was for extra safety. However, the CDN used by files.pythonhosted.org
does not return consistent etags for range requests, and this ended up
being something that I would override every time I used this library.
It's now opt-in.