Repository navigation
Treat 416 like 501 for unsupported suffix ranges - #10
Merged
Merged
Conversation
Some servers (e.g. fastly, in front of files.pythonhosted.org) reject an unsupported open-ended range request with 416 (Range Not Satisfiable) instead of 501 (Not Implemented), breaking the live tests. Fall back to a HEAD request on either status, and cover both urllib and requests backends with mocks. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The CDN in front of files.pythonhosted.org now honors the initial suffix-range request directly instead of rejecting it, so the optimistic-then-HEAD fallback no longer triggers and one fewer request is made.
mypy 1.8.0's bundled requests stub types HTTPError.response as Optional, so --strict flagged e.response.status_code as unsafe. An HTTPError with no response can't be classified as a range-support failure anyway, so re-raise it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live tests were failing because the server we hit most (fastly, in front of files.pythonhosted.org) can return 416 (Range Not Satisfiable) instead of 501 (Not Implemented) for an unsupported open-ended range request.
SeekableHttpFile.__init__now falls back to a HEAD request on either status code, with mocked tests covering both the urllib and requests backends.