Repository navigation
fix(deploy): drop managementMode + legacyProject gates from MCP source deploy and build - #116
Merged
Merged
Conversation
…e deploy and build Source deployment and build_publish required managementMode=managed and a linked legacy Project, blocking any deployment enrolled as a bare folder or container (track mode). The deploy itself runs off the linked GitHub repository + sourcePath + composePath, so both gates were redundant. Removed the gates in mcp-agent.ts (deployment.source.deploy), projects/compose/route.ts (source-deploy action), and projects/compose/build-publish/route.ts (build action). Any enrolled deployment with a linked GitHub repository and a compose path is now MCP-drivable with no manual 'manage' step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Source deployment (
deployment.source.deploy) andbuild_publishrequiredmanagementMode=managedand a linked legacyProject, which blocked any deployment enrolled as a bare folder or container (trackmode) from being driven through the MCP.Why
The actual deploy runs off the linked GitHub repository (
githubRepositoryDeployment→ GitHub App token),sourcePath(git sync target), andcomposePath(docker compose build/up). Neither the legacyProjectnormanagementModeis read by the deploy worker, so both gates were redundant blockers. New deployments should be MCP-drivable immediately — no manual "manage" step, no DB edit.Changes
src/lib/mcp-agent.ts— removed themanagementMode !== "managed"and!deployment.legacyProjectgates fromdeployment.source.deploy.src/app/api/projects/compose/route.ts— removed the!projectandmanagementMode !== "managed"gates from thesource-deployaction; enrollment matches onsourcePath/slugonly.src/app/api/projects/compose/build-publish/route.ts— removed the same two gates frombuild_publish.managementModeis retained as a display label; it no longer gates anything.Validation
npx tsc --noEmit— cleannpx vitest run— 502/502 passing (78 files)