Repository navigation
impact: command words skip the HQ4 state lock - #355
Merged
Merged
Conversation
Every 0x120400 command word took the HQ4 state mutex only to decide the port's phase, which after the first context switch is always the command phase. An atomic flag now mirrors that phase (a switch has completed and no selection has started another), set and cleared under the lock at the three places it changes: reset, the context-switch selection and the 63rd image word. A command word checks it and goes straight to the FIFO; the image, the pre-switch packets and stray words keep the locked path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every 0x120400 command word took the HQ4 state mutex only to decide the port's phase, which after the first context switch is always the command phase. An atomic flag now mirrors that phase (a switch has completed and no selection has started another), set and cleared under the lock at the three places it changes: reset, the context-switch selection and the 63rd image word. A command word checks it and goes straight to the FIFO; the image, the pre-switch packets and stray words keep the locked path.