Repository navigation
ip30: build fix, remove merge cruft - #349
Merged
Merged
Conversation
techomancer#343 was written against the older Octane and its merge brought back OctaneMachine::service_loop, which calls Ip30Bus::service and save. Those went with the move onto Physical, so main does not compile. Nothing starts the loop; the Octane's devices run their own threads and timers. Remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#343 was written against the older Octane and its merge brought back OctaneMachine::service_loop, which calls Ip30Bus::service and save. Those went with the move onto Physical, so main does not compile.
The Octane's devices run their own threads and timers to the loop is irrelevant. Just remove it.