Repository navigation
Add CI with HTML validation, fix 22 html-validate findings, refresh Pages actions - #1
Merged
Merged
Conversation
… actions - CI workflow: node --check app.js, html-validate 11.16.2 on index.html, and a required-assets check (index.html, styles.css, app.js, .nojekyll) - index.html: explicit type attributes on buttons/inputs, search box wrapper changed from label to div (multi-control label), removed redundant label for attributes, doctype normalized to uppercase - Pages deploy: checkout@v7, configure-pages@v6, upload-pages-artifact@v5 (with include-hidden-files so .nojekyll ships), deploy-pages@v5 - Dependabot for GitHub Actions, .editorconfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds CI to a site that had none, fixes everything it found, and refreshes the Pages deployment to current actions.
CI (
.github/workflows/ci.yml, runs on every push/PR)node --check app.js— syntax checkhtml-validate@11.16.2 index.html— HTML validationindex.html,styles.css,app.js,.nojekyll) so a rename can't silently break the deployHTML fixes (all behavior-preserving, 22 html-validate errors -> 0)
type=buttonon buttons outside forms, explicittype=texton text inputs<label>to<div>(it contained two controls; the input already hasaria-label)forattributes on labels that wrap their control<!doctype html>-><!DOCTYPE html>Pages deployment refresh
actions/checkout@v4 -> v7,configure-pages@v5 -> v6,upload-pages-artifact@v3 -> v5,deploy-pages@v4 -> v5include-hidden-files: true— upload-pages-artifact v4+ excludes dotfiles by default, which would have dropped.nojekyllfrom the published siteHygiene
.editorconfigVerification